fix: Hao xu request source timestamp_field (feast-dev#4495)

* not sure why fix linting Signed-off-by: cmuhao <[email protected]> * not sure why fix linting Signed-off-by: cmuhao <[email protected]> --------- Signed-off-by: cmuhao <[email protected]>
lokeshrangineni · Sep 6, 2024 · 96344b2 · 96344b2
1 parent 4a6b663
commit 96344b2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -187,6 +187,7 @@ The list below contains the functionality that contributors are planning to deve
   * [x] On-demand Transformations (Beta release. See [RFC](https://docs.google.com/document/d/1lgfIw0Drc65LpaxbUu49RCeJgMew547meSJttnUqz7c/edit#))
   * [x] Streaming Transformations (Alpha release. See [RFC](https://docs.google.com/document/d/1UzEyETHUaGpn0ap4G82DHluiCj7zEbrQLkJJkKSv4e8/edit))
   * [ ] Batch transformation (In progress. See [RFC](https://docs.google.com/document/d/1964OkzuBljifDvkV-0fakp2uaijnVzdwWNGdz7Vz50A/edit))
+  * [ ] Persistent On-demand Transformations (Beta release. See [GitHub Issue](https://github.com/feast-dev/feast/issues/4376))
 * **Streaming**
   * [x] [Custom streaming ingestion job support](https://docs.feast.dev/how-to-guides/customizing-feast/creating-a-custom-provider)
   * [x] [Push based streaming data ingestion to online store](https://docs.feast.dev/reference/data-sources/push)
@@ -208,6 +209,9 @@ The list below contains the functionality that contributors are planning to deve
   * [x] Amundsen integration (see [Feast extractor](https://github.com/amundsen-io/amundsen/blob/main/databuilder/databuilder/extractor/feast_extractor.py))
   * [x] DataHub integration (see [DataHub Feast docs](https://datahubproject.io/docs/generated/ingestion/sources/feast/))
   * [x] Feast Web UI (Beta release. See [docs](https://docs.feast.dev/reference/alpha-web-ui))
+  * [ ] Feast Lineage Explorer
+* **Natural Language Processing**
+  * [x] Vector Search (Alpha release. See [RFC](https://docs.google.com/document/d/18IWzLEA9i2lDWnbfbwXnMCg3StlqaLVI-uRpQjr_Vos/edit#heading=h.9gaqqtox9jg6))
 
 
 ## 🎓 Important Resources
@@ -230,4 +234,4 @@ Thanks goes to these incredible people:
 
 <a href="https://github.com/feast-dev/feast/graphs/contributors">
   <img src="https://contrib.rocks/image?repo=feast-dev/feast" />
-</a>
+</a>
diff --git a/sdk/python/feast/data_source.py b/sdk/python/feast/data_source.py
@@ -524,12 +524,19 @@ def __init__(
         *,
         name: str,
         schema: List[Field],
+        timestamp_field: Optional[str] = None,
         description: Optional[str] = "",
         tags: Optional[Dict[str, str]] = None,
         owner: Optional[str] = "",
     ):
         """Creates a RequestSource object."""
-        super().__init__(name=name, description=description, tags=tags, owner=owner)
+        super().__init__(
+            name=name,
+            timestamp_field=timestamp_field,
+            description=description,
+            tags=tags,
+            owner=owner,
+        )
         self.schema = schema
 
     def validate(self, config: RepoConfig):
@@ -570,6 +577,7 @@ def from_proto(data_source: DataSourceProto):
         return RequestSource(
             name=data_source.name,
             schema=list_schema,
+            timestamp_field=data_source.timestamp_field,
             description=data_source.description,
             tags=dict(data_source.tags),
             owner=data_source.owner,
@@ -593,6 +601,7 @@ def to_proto(self) -> DataSourceProto:
             tags=self.tags,
             owner=self.owner,
         )
+        data_source_proto.timestamp_field = self.timestamp_field
         data_source_proto.request_data_options.schema.extend(schema_pb)
 
         return data_source_proto