Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Client lib: make request label option mandatory #88

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

eduard-fa
Copy link
Contributor

@eduard-fa eduard-fa commented Dec 13, 2023

Changes

Based on our internal discussion, we make requestLabel mandatory to ensure it is always present in our requests.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

Based on our internal discussion, we make requestLabel mandatory
to ensure it is always present in our requests.y
@kibertoad
Copy link
Collaborator

It's a semver major.

@eduard-fa
Copy link
Contributor Author

It's a semver major.

While it is a breaking change, I'm slightly hesitant to do a major version bump just because of that tiny change. Is it worth it? Could we postpone releasing it until we accrue a few more changes?

@kibertoad
Copy link
Collaborator

Numbers are cheap. Considering that we are not maintaining a migration guide, I would argue that smaller major releases are likely to be way easier to migrate to.
No strong opinion, though. If you prefer to defer, we can mark as skip-release.

@kibertoad
Copy link
Collaborator

Let's release this together with #90

@kibertoad kibertoad merged commit e6ead42 into main Dec 14, 2023
4 checks passed
@kibertoad kibertoad deleted the mandatory-request-label branch December 14, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants