Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PublicNonRecoverableError typeguard #79

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix PublicNonRecoverableError typeguard #79

merged 1 commit into from
Nov 16, 2023

Conversation

kibertoad
Copy link
Collaborator

Changes

Previously incorrect type was established within isPublicNonRecoverableError typeguard

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@kibertoad kibertoad merged commit 0168c51 into main Nov 16, 2023
4 of 5 checks passed
@kibertoad kibertoad deleted the fix/error-type-guard branch November 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosGamero CarlosGamero CarlosGamero approved these changes

@drdaemos drdaemos drdaemos approved these changes

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay

@lokankr lokankr Awaiting requested review from lokankr

@andris-sevcenko andris-sevcenko Awaiting requested review from andris-sevcenko

@ForterLokalise ForterLokalise Awaiting requested review from ForterLokalise

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibertoad @drdaemos @CarlosGamero