Convert date to string #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGamero
requested review from
kibertoad,
rupert-mckay,
lokankr,
drdaemos,
andris-sevcenko and
ForterLokalise
as code owners
kibertoad
reviewed
Nov 13, 2023
kibertoad
reviewed
Nov 13, 2023
| code: 100, | ||
| } | ||
|
|
||
| const output: TestExpectedType = convertDateFieldsToIsoString(input) |
There was a problem hiding this comment.
why do we need to do explicit type here? is it meant as a assert-like?
There was a problem hiding this comment.
The function is automatically inferring the type.
yes, it is like an assert to make sure the type is being inferred correctly
kibertoad
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding
convertDatesToIsoStringto transform an input object withDatemembers into an object with the correspondingDatemembers replaced by their ISO string representation. This transformation is done recursively, covering nested objects as well.Checklist
major,minor,patchorskip-release