Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string should count as null #65

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Empty string should count as null #65

merged 1 commit into from
Aug 4, 2023

Conversation

lokankr
Copy link
Contributor

@lokankr lokankr commented Aug 4, 2023

Changes

Treat empty string as a "null" value.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@lokankr lokankr added the patch label Aug 4, 2023
@lokankr lokankr added major and removed patch labels Aug 4, 2023
@lokankr lokankr changed the title Empty string should could as null Empty string should count as null Aug 4, 2023
@lokankr lokankr merged commit 75377bd into main Aug 4, 2023
@lokankr lokankr deleted the AP-246-any-falsy branch August 4, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay

@drdaemos drdaemos Awaiting requested review from drdaemos drdaemos is a code owner

@andris-sevcenko andris-sevcenko Awaiting requested review from andris-sevcenko

@ForterLokalise ForterLokalise Awaiting requested review from ForterLokalise

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lokankr @kibertoad