Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config get optional one of #60

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Config get optional one of #60

merged 4 commits into from
Jul 6, 2023

Conversation

CarlosGamero
Copy link
Contributor

@CarlosGamero CarlosGamero commented Jul 6, 2023 •
edited
Loading

Changes

Adding a new config method -> getOptionalOneOf

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@CarlosGamero CarlosGamero self-assigned this Jul 6, 2023
@CarlosGamero CarlosGamero marked this pull request as ready for review July 6, 2023 08:25
@CarlosGamero CarlosGamero requested a review from cameronsmith July 6, 2023 08:26
@CarlosGamero CarlosGamero mentioned this pull request Jul 6, 2023
Merged
kibertoad
kibertoad reviewed Jul 6, 2023
View reviewed changes
src/config/ConfigScope.ts Outdated Show resolved Hide resolved
kibertoad
kibertoad reviewed Jul 6, 2023
View reviewed changes
src/config/ConfigScope.ts Outdated Show resolved Hide resolved
@CarlosGamero CarlosGamero merged commit 65ec4ec into main Jul 6, 2023
@CarlosGamero CarlosGamero deleted the config_getOptionalOneOf branch July 6, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@drdaemos drdaemos drdaemos approved these changes

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay

@lokankr lokankr Awaiting requested review from lokankr

@andris-sevcenko andris-sevcenko Awaiting requested review from andris-sevcenko

@ForterLokalise ForterLokalise Awaiting requested review from ForterLokalise

@cameronsmith cameronsmith Awaiting requested review from cameronsmith

Assignees

@CarlosGamero CarlosGamero

Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlosGamero @drdaemos @kibertoad