Breaking change: Updated ConfigScope.getOptional to fallback to default value when environment variable is an empty string ('') #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Problem statement
Given
and performing
the produced configuration has inconsistent fallback behavior
Proposed solution
Use logical OR operator
||
instead of??
inConfigScope.getOptional
.Notes
Taking into account that `configScope.getOptional('VAR2', 'foo') currently returns an empty string, this change has the ability to break an application.
Both for applications that rely on this behaviour and the ones that were not aware of this fallback behaviour.
Checklist
major
,minor
,patch
orskip-release