Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize http client with the template #20

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Synchronize http client with the template #20

merged 2 commits into from
Nov 28, 2022

Conversation

kibertoad
Copy link
Collaborator

Changes

  • Adds support for requestContext with reqId
  • Adds support for sending binary content

Checklist

  • Apply one of following labels; major, minor, patch or skip-release

@kibertoad kibertoad requested a review from drdaemos November 27, 2022 14:42
lokankr
lokankr approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@lokankr lokankr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I'll need to look into getting request id into NR APM.

@kibertoad kibertoad merged commit 495af2f into main Nov 28, 2022
@kibertoad kibertoad deleted the feat/http-client branch November 28, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokankr lokankr lokankr approved these changes

@drdaemos drdaemos Awaiting requested review from drdaemos drdaemos is a code owner

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibertoad @lokankr