hide error symbol from being printed

[CatchMe2]

Changes

This PR prevents the error symbol from being printed.
console.log output of the previous implementation:

console.log output of the new implementation

Checklist

• Apply one of following labels; major, minor, patch or skip-release
• I've updated the documentation, or no changes were necessary
• I've updated the tests, or no changes were necessary

[drdaemos]

Is there is a specific reason to this change?
e.g. why don’t we want to have this symbol printed?

[kibertoad]

why this change? this method was deprecated AFAIR

[CatchMe2]

It's not depreciated: https://nodejs.org/api/util.html#utiltypesisnativeerrorvalue
I think that it's better to use std lib solutions

[kibertoad]

ok, then it makes sense

[CatchMe2]

Is there is a specific reason to this change? e.g. why don’t we want to have this symbol printed?

This symbol was meant to be internal, used for instance check only. It doesn't provide any valuable info.

[CatchMe2]

After a discussion, we decided to leave printing it as before.

[CarlosGamero]

Not sure if related, but I am getting the following on my PR:

Property '[internalErrorSymbol]' is missing in type 'import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").InternalError<import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").ErrorDetails>' but required in type 'import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").InternalError<import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").ErrorDetails>'.

https://github.com/lokalise/autopilot/actions/runs/11363730214/job/31608342987?pr=4496

[CatchMe2]

Not sure if related, but I am getting the following on my PR:

Property '[internalErrorSymbol]' is missing in type 'import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").InternalError<import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").ErrorDetails>' but required in type 'import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").InternalError<import("/Users/[email protected]/development/Node/autopilot/node_modules/@lokalise/node-core/dist/index").ErrorDetails>'.

https://github.com/lokalise/autopilot/actions/runs/11363730214/job/31608342987?pr=4496

Using

Object.defineProperty(InternalError.prototype, INTERNAL_ERROR_SYMBOL, {
  value: true,
})

Should resolve this problem as it would make the SYMBOL property invisible to type checking as well.