Adding EntityGoneError #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariacm
approved these changes
May 16, 2024
kibertoad
reviewed
May 16, 2024
| @@ -54,6 +54,17 @@ export class EntityNotFoundError extends PublicNonRecoverableError { | |||
| } | |||
| } | |||
|
|
|||
| export class EntityGoneError extends PublicNonRecoverableError { | |||
There was a problem hiding this comment.
do we ever need to instanceof check it? wonder if we need a flag on it, and a typeguard
There was a problem hiding this comment.
Good point, yeah, we would need the instanceof in some cases
There was a problem hiding this comment.
typeguard added, not sure what do you mean by the flag, but please have a look to see if it makes sense 🙏
Note: all 410 http errors considered as entityGone, no matter if it was created as a PublincNonRecoverableError
There was a problem hiding this comment.
common technique for simple typeguards is adding a field like "isEntityGone: true" so that you could do a single-field check, but you are right, in this case http code check is a better option!
kibertoad
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding entity gone error, useful to send back that the entity does no longer exists
Checklist
major,minor,patchorskip-release