Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isLevelEnabled to common logger interface #126

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add isLevelEnabled to common logger interface #126

merged 1 commit into from
Apr 25, 2024

Conversation

kibertoad
Copy link
Collaborator

Changes

We rely on this method in bg-jobs-common lib, would be nice to have on a common interface.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@kibertoad kibertoad requested review from drdaemos, CarlosGamero and a team as code owners April 25, 2024 20:09
@kibertoad kibertoad merged commit 008de86 into main Apr 25, 2024
6 checks passed
@kibertoad kibertoad deleted the feat/is-level-enabled branch April 25, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosGamero CarlosGamero CarlosGamero approved these changes

@dariacm dariacm dariacm approved these changes

@drdaemos drdaemos Awaiting requested review from drdaemos drdaemos is a code owner

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibertoad @dariacm @CarlosGamero