Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/transloco: add support for prefix: to work alongside read: #1140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bratzie
Copy link
Contributor

@bratzie bratzie commented May 14, 2024

Hello!

Since Transloco 7.1.0+ they have renamed the read: syntax to prefix:.

Link to relevant docs: https://jsverse.github.io/transloco/docs/translation-in-the-template#utilizing-the-prefix-input

The functionality is identical, but support for read: will be removed in the next major version.

I tweaked the regex to allow for both syntaxes to work as well as updating the related comment in the code to point to the correct point in the Transloco docs.

@bratzie
Copy link
Contributor Author

bratzie commented May 14, 2024

The failing test checks on windows/mac don't seem to be related to my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant