-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mysql storage #777
base: main
Are you sure you want to change the base?
Mysql storage #777
Conversation
Add a new storage type option that stores package contents in MySql along with the package metadata. Though MySql is not the best for storing large file contents, this is an alternative to storing package contents in the file system, which should be better for highly-available/distributed use cases.
More information about our use case. We run BaGet in multiple datacenters pointing to a MySql database. Since BaGet only supports saving package contents to the file system, we use a distributed file system to store those documents. However, distributed file systems are not perfect and sparing you the details, we think it would be better for us to store the package contents in our MySql database along with the package metadata so everything is in one place. I think this will not be an uncommon thought. |
@@ -133,6 +134,11 @@ private static void AddDefaultProviders(this IServiceCollection services) | |||
return provider.GetRequiredService<FileStorageService>(); | |||
} | |||
|
|||
if (configuration.HasStorageType("mysql")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized this should perhaps be "database" not "mysql". What do you think @loic-sharma?
migrationBuilder.AlterColumn<DateTime>( | ||
name: "RowVersion", | ||
table: "Packages", | ||
rowVersion: true, | ||
nullable: true, | ||
oldClrType: typeof(DateTime), | ||
oldType: "timestamp(6)", | ||
oldNullable: true) | ||
.Annotation("MySql:ValueGenerationStrategy", MySqlValueGenerationStrategy.ComputedColumn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was tempted to remove this but I see it is in every other migration file. Do you have a preference?
Add a new storage type option that stores package contents in MySql
along with the package metadata.
Though MySql is not the best for storing large file contents, this is an
alternative to storing package contents in the file system, which should be
better for highly-available/distributed use cases.