Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the release notes length limit #687

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

loic-sharma
Copy link
Owner

@loic-sharma loic-sharma commented Sep 19, 2021

Kudos to @dncnkrs for the original implementation in #610.

Allow BaGet to index packages with large release notes. For example: https://www.nuget.org/packages/chocolatey/0.10.6.1

  • Test migration on new database:

    • MySQL
    • PostgreSQL
    • SQL Server
    • SQLite
  • Test migration on existing database:

    • MySQL
    • PostgreSQL
    • SQL Server
    • SQLite
  • Test indexing package with long release notes:

    • MySQL
    • PostgreSQL
    • SQL Server
    • SQLite

Addresses #609

oldClrType: typeof(DateTime),
oldType: "timestamp(6)",
oldNullable: true)
.Annotation("MySql:ValueGenerationStrategy", MySqlValueGenerationStrategy.ComputedColumn);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sketch but from my testing it doesn't seem to cause any problems... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant