Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded package icons #469

Merged
merged 23 commits into from
Feb 10, 2020
Merged

Conversation

loic-sharma
Copy link
Owner

@loic-sharma loic-sharma commented Feb 10, 2020

NuGet supports embedding the package's icon into the package itself. This adds the necessary logic to support embedded icons in BaGet. Based off @iodes changes: #423

Test plan
  • Ingestion
    • MySQL
      • Upload package with iconUrl (before migration)
      • Upload package with icon (before migration)
      • Apply migration
      • Upload package with iconUrl
      • Upload package with icon
    • PostgreSQL
      • Upload package with iconUrl (before migration)
      • Upload package with icon (before migration)
      • Apply migration
      • Upload package with iconUrl
      • Upload package with icon
    • SQLite
      • Upload package with iconUrl (before migration)
      • Upload package with icon (before migration)
      • Apply migration
      • Upload package with iconUrl
      • Upload package with icon
    • SQL Server
      • Upload package with iconUrl (before migration)
      • Upload package with icon (before migration)
      • Apply migration
      • Upload package with iconUrl
      • Upload package with icon
    • Azure Table
      • Upload package with iconUrl (before migration)
      • Upload package with icon (before migration)
      • Apply migration
      • Upload package with iconUrl
      • Upload package with icon
  • Search
    • Providers
      • Database (for each database)
      • Azure Search
        • Upload package with iconUrl (before migration)
        • Upload package with icon (before migration)
        • Apply migration
        • Upload package with iconUrl
        • Upload package with icon
        • Check HasEmbeddedIcon value
    • Check embedded icon search result
    • Check legacy iconUrl search result
  • Storage
    • File system
    • Azure Blob Storage
  • Clients
    • Website (Chrome, Firefox, Edge)
    • Visual Studio

@loic-sharma loic-sharma changed the title Support embedded package icon Support embedded package icons Feb 10, 2020
@loic-sharma loic-sharma merged commit bd44019 into master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants