Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/text props #16

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

BLOCKMATERIAL
Copy link
Contributor

@BLOCKMATERIAL BLOCKMATERIAL commented Oct 31, 2023

Description

Having encountered some problems in production I was motivated to add textStyle only textProps so that we could add documented props for the native Text component, e.g. disabling text scaling and other described properties.

Feature : added textProps for apply some property to native component

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🔥 Breaking change
  • 💣 Package Update
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert
  • 🏰 Code style update (formatting, local variables)

How Has This Been Tested?

Screenshots/Recordings (if appropriate):

Related Tickets & Documents

Additional note for QA team:

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My changes don't decrease Code Coverage percentage

@BLOCKMATERIAL
Copy link
Contributor Author

@younes0 @lohenyumnam can't assign to you but ping you

@lohenyumnam lohenyumnam merged commit e3f947f into lohenyumnam:master Nov 1, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants