Bottom nav bar should depend on flag #2
Conversation
lib/src/viewer.dart
Outdated
| @@ -225,7 +225,7 @@ class _PDFViewerState extends State<PDFViewer> { | |||
| ) | |||
| : null, | |||
| floatingActionButtonLocation: FloatingActionButtonLocation.centerDocked, | |||
| bottomNavigationBar: (widget.showNavigation || widget.document.count > 1) | |||
| bottomNavigationBar: widget.showNavigation | |||
There was a problem hiding this comment.
Instead of removing the 2nd part of the condition, we can just change OR to AND.
There was a problem hiding this comment.
Can you please take a look at this PR @lohanidamodar
There was a problem hiding this comment.
@Monal5031 I believe your suggestion is better, as we don't want the navigation shown even if the showNavigation is true and page count is just 1. AND instead of removing second condition seems better.
|
this would be great ;) I struggled to find the problem untill i saw the condition in the code, and this issue. |
|
@dimitri-bret There is a workaround you can use, until this is merged. pass |
There was a problem hiding this comment.
Can you please use && instead of removing second condition? That's a better solution as mentioned by @Monal5031 .
Thank you for your PR and support
|
Added the requested change @lohanidamodar |
Fixing an issue where settings
showNavigationto false didn't do anything.Similar bug on forked repo CrossPT#57