Add toleration to all DaemonSets #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jlewis42lines Thank you for opening this PR |
|
@Doron-Bargo Any movement on this? |
mirii1994
suggested changes
Nov 25, 2020
By default, add a blanket toleration to the filebeat and metricbeat DaemonSets, with the opertion to remove the toleration and accept all taints (for backward compatibility).
Co-authored-by: Miri <[email protected]>
Co-authored-by: Miri <[email protected]>
Co-authored-by: Miri <[email protected]>
Co-authored-by: Miri <[email protected]>
jeffreymlewis
force-pushed
the
jl/daemonset-tolerations
branch
from
36da18f
to
7636ece
Compare
Hi @mirii1994, Sounds good to me. I've accepted you changes and rebased against upstream/master. Let me know if you need any other changes. Also let me know if you want me to squash all commits before merging. |
mirii1994
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, add a blanket toleration to the filebeat and metricbeat DaemonSets, with the option to remove the toleration and accept all taints (for backward compatibility).
This is technically a breaking change, as it changes the current default behavior. However, I think most people will want the DaemonSet pods to ignore all taints, so I believe this is the proper default going forward.