-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toleration to all DaemonSets #23
Add toleration to all DaemonSets #23
Conversation
Hi @jlewis42lines Thank you for opening this PR |
@Doron-Bargo Any movement on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jlewis42lines , thanks for your contribution and sorry for the late response, this looks great!
I do think we should add it as an option rather than making it a default behaviour.
By default, add a blanket toleration to the filebeat and metricbeat DaemonSets, with the opertion to remove the toleration and accept all taints (for backward compatibility).
Co-authored-by: Miri <[email protected]>
Co-authored-by: Miri <[email protected]>
Co-authored-by: Miri <[email protected]>
Co-authored-by: Miri <[email protected]>
36da18f
to
7636ece
Compare
Hi @mirii1994, Sounds good to me. I've accepted you changes and rebased against upstream/master. Let me know if you need any other changes. Also let me know if you want me to squash all commits before merging. |
By default, add a blanket toleration to the filebeat and metricbeat DaemonSets, with the option to remove the toleration and accept all taints (for backward compatibility).
This is technically a breaking change, as it changes the current default behavior. However, I think most people will want the DaemonSet pods to ignore all taints, so I believe this is the proper default going forward.