Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade packages and update code following it #45

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Sep 17, 2024

Description

This pr closes #43 closes #40 closes #39 closes #38 closes #37 closes #34 closes #24 closes #23 closes #22 closes #21 closes #20 closes #13 closes #12 closes #10

  • Change the deprecated @opentelemetry/sdk-metrics-base package to @opentelemetry/sdk-metrics
    • Update the code based on the update to support the new structure
    • Update the tests
  • Change logzio-shipper >> User-Agent header and make the version not hardcoded
  • Update packages versions
  • Update workflow versions
  • Drop support for Nodejs 12
    • In Nodejs 14 optional chaining was introduced and it's used in dependencies
  • Update readme

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

@8naama 8naama changed the title [BUG] Upgrade packages and code [BUG] Upgrade packages and update code following it Sep 17, 2024
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@yotamloe yotamloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, please see my comments

@8naama 8naama merged commit 24f29f3 into main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants