Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add vonage connector #6768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wangsijie
Copy link
Contributor

Summary

Add Vonage SMS connector.

Testing

截屏2024-11-05 10 57 17 截屏2024-11-05 10 57 24 截屏2024-11-05 10 58 59

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the feature Cool stuff label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +18.46 KB

Diff by File
Name Diff
packages/connectors/connector-vonage-sms/README.md 📈 +1.56 KB
packages/connectors/connector-vonage-sms/logo.svg 📈 +495 Bytes
packages/connectors/connector-vonage-sms/package.json 📈 +1.66 KB
packages/connectors/connector-vonage-sms/src/constant.ts 📈 +1.7 KB
packages/connectors/connector-vonage-sms/src/index.test.ts 📈 +320 Bytes
packages/connectors/connector-vonage-sms/src/index.ts 📈 +1.81 KB
packages/connectors/connector-vonage-sms/src/mock.ts 📈 +445 Bytes
packages/connectors/connector-vonage-sms/src/types.ts 📈 +1019 Bytes
packages/console/src/components/CreateConnectorForm/index.tsx 📈 +105 Bytes
pnpm-lock.yaml 📈 +9.41 KB

Copy link
Contributor

@darcyYe darcyYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


To work with this connector, you will need to [sign up for an account](https://developer.vonage.com/en/account/guides/dashboard-management#create-and-configure-a-vonage-account) in Vonage. This will give you an API key and secret that you can use to access the APIs through this connector.

Once you have an account, you can find your API Key and API Secret at the top of the Vonage API Dashboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
Once you have an account, you can find your API Key and API Secret at the top of the Vonage API Dashboard.
Once you have an account, you can find your API key and API secret at the top of the Vonage API Dashboard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like to keep API Key then you probably need to change the letter case at line 9


Vonage is a global communications provider, offering robust cloud-based communication services, including SMS (short message service). The Vonage SMS Connector is a plugin provided by the Logto team to enable Logto end-users to register and sign in to their Logto account via SMS verification codes.

## Set Up in Vonage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Set Up in Vonage
## Set up in Vonage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get a dark logo as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants