style(experience): update the devTenantNotification style #6745
+30
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the devTenantNotification style
simeng-li
requested review from
xiaoyijun,
a team,
wangsijie and
charIeszhao
and removed request for
a team
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/experience-legacy/src/App.tsx | 📉 -134 Bytes |
| packages/experience-legacy/src/Layout/AppLayout/index.tsx | 📉 -132 Bytes |
| packages/experience-legacy/src/containers/DevelopmentTenantNotification/index.tsx | 📉 -25 Bytes |
| packages/experience/src/App.tsx | 📉 -134 Bytes |
| packages/experience/src/Layout/AppLayout/index.tsx | 📉 -132 Bytes |
| packages/experience/src/containers/DevelopmentTenantNotification/index.tsx | 📉 -25 Bytes |
|
Will the logo be blocked by this banner on the mobile page, or will the space above the logo become smaller? |
We have the logo height size limited to a specific number. Should not block for most of the cases. But technically, if the logo is oversized, it will be blocked. |
charIeszhao
approved these changes
Nov 4, 2024
simeng-li
deleted the
simeng-log-10289-dev-tenant-banner-update-dev-tenant-banner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the devTenantNotification style
Summary
Update the dev tenant notification banner using the latest design.
Testing
Checklist
.changeset