fix(console): refactor TenantxContext util methods #6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/contexts/SubscriptionDataProvider/use-new-subscription-data.ts | 📈 +7 Bytes |
| packages/console/src/contexts/TenantsProvider.tsx | 📈 +239 Bytes |
darcyYe
force-pushed
the
yemq-revert-remove-isAddOnAvailable
branch
from
449ee8d
to
33d3409
Compare
darcyYe
force-pushed
the
yemq-revert-remove-isAddOnAvailable
branch
from
33d3409
to
fd9ffdd
Compare
darcyYe
force-pushed
the
yemq-revert-remove-isAddOnAvailable
branch
from
fd9ffdd
to
8db2d86
Compare
darcyYe
changed the title
darcyYe
requested review from
wangsijie,
charIeszhao,
xiaoyijun and
gao-sun
as code owners
wangsijie
reviewed
Oct 23, 2024
packages/console/src/contexts/SubscriptionDataProvider/use-new-subscription-data.ts
Outdated
Show resolved
Hide resolved
darcyYe
changed the title
wangsijie
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix cloud CI failed issue by wrapping TenantsContext utils methods with useCallback to prevent unnecessary re-render.
This rerender sometimes triggers infinite loops.
Testing
Tested with Cloud CI.
Checklist
.changeset