Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(console): update radio card style #6700

Merged

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented Oct 21, 2024

Summary

Update radio card style. This PR includes the following updates:

  1. Replace the Check icon in the Radio card component using the latest resource
  2. Gives extra padding to the Radio card title.
  3. Change the disabled Radio card text color. Should use the default text color.
image

Testing

test locally

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Oct 21, 2024

COMPARE TO master

Total Size Diff 📈 +516 Bytes

Diff by File
Name Diff
packages/console/src/ds-components/RadioGroup/Radio.tsx 📈 +121 Bytes
packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/ConfigForm.tsx 📈 +362 Bytes
packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/index.module.scss 📈 +135 Bytes
packages/console/src/pages/EnterpriseSsoDetails/index.tsx 📈 +52 Bytes
packages/phrases/src/locales/en/translation/admin-console/enterprise-sso-details.ts 📈 +154 Bytes

@simeng-li simeng-li requested review from a team October 21, 2024 06:27
@simeng-li simeng-li force-pushed the simeng-log-10257-handle-dropdown-default-values branch from 71d2d6a to 414913d Compare October 22, 2024 03:16
@simeng-li simeng-li force-pushed the simeng-log-10258-add-extra-padding-around-the-checkmark branch from 05e610a to bcd4f69 Compare October 22, 2024 03:18
Base automatically changed from simeng-log-10257-handle-dropdown-default-values to master October 22, 2024 03:36
* style(console,phrases): update selector styles

update selector styles and content

* style(console): adjust font size

adjust font size
@simeng-li simeng-li force-pushed the simeng-log-10258-add-extra-padding-around-the-checkmark branch from df8b3eb to dc8263b Compare October 22, 2024 03:36
@simeng-li simeng-li enabled auto-merge (squash) October 22, 2024 03:38
@simeng-li simeng-li merged commit 95c7d8b into master Oct 22, 2024
35 checks passed
@simeng-li simeng-li deleted the simeng-log-10258-add-extra-padding-around-the-checkmark branch October 22, 2024 03:54
darcyYe pushed a commit that referenced this pull request Oct 22, 2024
* style(console): update radio card style

update radio card style

* style(console,phrases): update selector styles (#6702)

* style(console,phrases): update selector styles

update selector styles and content

* style(console): adjust font size

adjust font size

* fix(console): add devFeatureGuard

add devFeatureGuard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants