feat(core): database connection timeout env overwrite support (#6187) #6674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis815
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/fifty-apes-arrive.md | 📈 +369 Bytes |
| packages/core/src/env-set/create-pool.ts | 📈 +53 Bytes |
| packages/core/src/env-set/index.ts | 📈 +92 Bytes |
| packages/shared/src/node/env/GlobalValues.ts | 📈 +102 Bytes |
4 tasks
wangsijie
approved these changes
Oct 16, 2024
|
I think we need to add a changeset. I will take care of it and we'll merge the PR right after that. Thanks again for your contribution. |
darcyYe
approved these changes
Oct 16, 2024
charIeszhao
force-pushed
the
developer/luis815
branch
from
8bc98e7
to
aa3d1a0
Compare
charIeszhao
changed the title
gao-sun
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding environmental variable to overwrite default database connection timeout, as the default value is causing some instances fail to start.
Default value for createPool is documented here
Testing
Locally by verifying value is passed to
@silverhand/slonik createPooland application startsChecklist
.changeset