New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init management api hook middleware function #5783

Merged

simeng-li merged 14 commits into master from gao-init-management-api-hooks

May 9, 2024

Merged

feat: init management api hook middleware function #5783

refactor(core): clean up some management api webhook code

GitHub Actions / ESLint Report Analysis succeeded May 6, 2024 in 1s

ESLint Report Analysis

0 ESLint error(s) and 12 ESLint warning(s) found in pull request changed files.

Details

Annotations

Check warning on line 13 in packages/console/src/components/BasicWebhookForm/index.tsx

github-actions / ESLint Report Analysis

packages/console/src/components/BasicWebhookForm/index.tsx#L13

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Implement all hook events'.

Check warning on line 5 in packages/console/src/consts/webhooks.ts

github-actions / ESLint Report Analysis

packages/console/src/consts/webhooks.ts#L5

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Implement all hook events'.

Check warning on line 16 in packages/console/src/consts/webhooks.ts

github-actions / ESLint Report Analysis

packages/console/src/consts/webhooks.ts#L16

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Implement all hook events'.

Check warning on line 24 in packages/console/src/pages/WebhookDetails/WebhookLogs/index.tsx

github-actions / ESLint Report Analysis

packages/console/src/pages/WebhookDetails/WebhookLogs/index.tsx#L24

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Implement all hook events'.

Check warning on line 100 in packages/console/src/pages/WebhookDetails/WebhookLogs/index.tsx

github-actions / ESLint Report Analysis

packages/console/src/pages/WebhookDetails/WebhookLogs/index.tsx#L100

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Implement all hook events'.

Check warning on line 96 in packages/console/src/pages/Webhooks/index.tsx

github-actions / ESLint Report Analysis

packages/console/src/pages/Webhooks/index.tsx#L96

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Implement all hook events'.

Check warning on line 24 in packages/core/src/libraries/hook/context-manager.ts

github-actions / ESLint Report Analysis

packages/core/src/libraries/hook/context-manager.ts#L24

[no-warning-comments] Unexpected 'todo' comment: 'TODO: @simeng-li migrate the current...'.

Check warning on line 39 in packages/core/src/libraries/hook/index.ts

github-actions / ESLint Report Analysis

packages/core/src/libraries/hook/index.ts#L39

[no-warning-comments] Unexpected 'todo' comment: 'TODO: @gao should we use the library...'.

Check warning on line 30 in packages/core/src/middleware/koa-management-api-hooks.ts

github-actions / ESLint Report Analysis

packages/core/src/middleware/koa-management-api-hooks.ts#L30

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Remove dev feature guard'.

Check warning on line 55 in packages/core/src/middleware/koa-management-api-hooks.ts

github-actions / ESLint Report Analysis

packages/core/src/middleware/koa-management-api-hooks.ts#L55

[no-warning-comments] Unexpected 'todo' comment: 'TODO: @simeng-li do we need to insert...'.

Check warning on line 64 in packages/core/src/routes/interaction/middleware/koa-interaction-hooks.ts

github-actions / ESLint Report Analysis

packages/core/src/routes/interaction/middleware/koa-interaction-hooks.ts#L64

[no-warning-comments] Unexpected 'todo' comment: 'TODO: @simeng-li Add DataHookContext to...'.

Check warning on line 18 in packages/schemas/src/foundations/jsonb-types/hooks.ts

github-actions / ESLint Report Analysis

packages/schemas/src/foundations/jsonb-types/hooks.ts#L18

[no-warning-comments] Unexpected 'todo' comment: 'TODO: @simeng-li implement more data...'.

View more details on GitHub Actions