Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): azure active directory connector added #1662

Merged
merged 6 commits into from
Jul 26, 2022

Conversation

ufuf
Copy link
Contributor

@ufuf ufuf commented Jul 23, 2022

Summary

Azure Active Directory connector added.

Testing

I ran the container in my local and created a brand new Azure account following the Readme I wrote. After entering the necessary credentials, I successfully logged in to logto with the Azure account and checked the user through the User Management tab.

Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is awesome. my teammate will go through the code and figure out a solution for verifier.

packages/connector-azuread/README.md Outdated Show resolved Hide resolved
packages/connector-azuread/README.md Outdated Show resolved Hide resolved
packages/connector-azuread/README.md Outdated Show resolved Hide resolved
packages/connector-azuread/docs/config-template.json Outdated Show resolved Hide resolved
packages/connector-azuread/package.json Outdated Show resolved Hide resolved
packages/connector-azuread/src/types.ts Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/connector-azuread/src/index.ts Outdated Show resolved Hide resolved
packages/connector-azuread/src/index.ts Outdated Show resolved Hide resolved
@gao-sun
Copy link
Member

gao-sun commented Jul 23, 2022

btw

  • you can try to rebase master branch and force push to this branch, since some workflows are changed.
  • we require every commit to be signed, to legally prove your commit are yours. :-)

@gao-sun gao-sun force-pushed the feature_AzureAD-connector branch 2 times, most recently from ab9d197 to 09c28e6 Compare July 26, 2022 14:49
@gao-sun
Copy link
Member

gao-sun commented Jul 26, 2022

i tested the new code locally, works like a charm

Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@gao-sun gao-sun merged commit 875a828 into logto-io:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants