Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): support extra sign-in params in angular #829

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat(angular): support extra sign-in params in angular #829

merged 2 commits into from
Oct 15, 2024

Conversation

charIeszhao
Copy link
Member

Summary

Support extra sign-in params in angular

Testing

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@charIeszhao charIeszhao self-assigned this Oct 14, 2024
wangsijie
wangsijie approved these changes Oct 15, 2024
View reviewed changes
packages/js/src/utils/angular.ts Show resolved Hide resolved
xiaoyijun
xiaoyijun approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@xiaoyijun xiaoyijun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

packages/js/src/utils/angular.ts Outdated Show resolved Hide resolved
@charIeszhao charIeszhao force-pushed the charles-log-9422-angular branch 2 times, most recently from b36c054 to 221bbfd Compare October 15, 2024 03:24
@charIeszhao charIeszhao enabled auto-merge (squash) October 15, 2024 03:37
@charIeszhao charIeszhao merged commit 7980dec into master Oct 15, 2024
20 checks passed
@charIeszhao charIeszhao deleted the charles-log-9422-angular branch October 15, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyijun xiaoyijun xiaoyijun approved these changes

@wangsijie wangsijie wangsijie approved these changes

Assignees

@charIeszhao charIeszhao

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charIeszhao @wangsijie @xiaoyijun