feat(connector): add discord connector (logto-io/logto#1876)

[FlurryNight]

Summary

Add Discord connector (logto-io/logto#1876)

Testing

UT and Locally Tested

[FlurryNight]

@darcyYe ,thanks for re-approving the workflows.

Should i add an eslint disable complexity comment, keeps trowing that because of the discord avatar url xD, if i remove it it passes locally, can u look into it? Is there a better way i can do that. Discord doesn't pass an url for the avatar..

Thanks again

[darcyYe]

@darcyYe ,thanks for re-approving the workflows.

Should i add an eslint disable complexity comment, keeps trowing that because of the discord avatar url xD, if i remove it it passes locally, can u look into it? Is there a better way i can do that. Discord doesn't pass an url for the avatar..

Thanks again

Hi @FlurryNight, you may disable the complexity lint rule to make it pass the check as it should not be a blocker.

[FlurryNight]

@darcyYe , Done the suggested changes, Lets see if this suppresses the need for the /* eslint-disable complexity */

[FlurryNight]

I think i've removed smth by mistake , im on mobile just received the failed notification , let me see

[FlurryNight]

Should be building 🛠 fine now, i did those changes on mobile, Dcoder editor must have passed out 😂

[darcyYe]

No worries!
Let me try the Discord connector's functionality (I could not test it yesterday due to some minor bugs in our core).
The code looks good 😄

[FlurryNight]

No worries!
Let me try the Discord connector's functionality (I could not test it yesterday due to some minor bugs in our core).
The code looks good 😄

Okay, however eslint is not happy yet, want me to add the disable rule comment?

[darcyYe]

Hi @FlurryNight, I've tried the connector and it worked smoothly!
You may disable the complexity lint rule, or I can do that for you. I'll double-check the version of the dependencies and some other details before approving, cheers!

[charIeszhao]

Looks good to me

[FlurryNight]

Damn, forgot to update the getUserInfo UT, let me see if i can do that quick on my phone should be just adding verified field

[FlurryNight]

@charIeszhao ,changed , can u verify it for me?

Thanks

[darcyYe]

no worries, after an offline discussion with @charIeszhao, we may keep both email and verified for future use. Would you mind me making the change to your code? @FlurryNight

[FlurryNight]

no worries, after an offline discussion with @charIeszhao, we may keep both email and verified for future use. Would you mind me making the change to your code? @FlurryNight

Okay, go ahead!

[darcyYe]

@FlurryNight can we temporarily hold this PR for a few days until early next week?
The change I intended to make depends on the @logto/connector-core package, which shares the same version as @logto/core repo does. We need to update @logto/connector-core before making changes to your code. We may find a temporary solution if you want to merge this PR ASAP. Let me know what you would like 😃

[FlurryNight]

@FlurryNight can we temporarily hold this PR for a few days until early next week?
The change I intended to make depends on the @logto/connector-core package, which shares the same version as @logto/core repo does. We need to update @logto/connector-core before making changes to your code. We may find a temporary solution if you want to merge this PR ASAP. Let me know what you would like 😃

Hi, Alright.
I agree with the way you think is best.

[darcyYe]

@FlurryNight , we have @logto/connector-core published and made the change to expose email_verified as UserInfoResponse. I'll have this PR merged, and Logto Team will release a new version of @logto/connectors this weekend, cheers!
Great thanks for building the Discord connector!

[FlurryNight]

@FlurryNight , we have @logto/connector-core published and made the change to expose email_verified as UserInfoResponse. I'll have this PR merged, and Logto Team will release a new version of @logto/connectors this weekend, cheers!
Great thanks for building the Discord connector!

Amazing, you're welcome

Cheers!