Make the package typed #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVanEldik
force-pushed
the
chore/add-typing
branch
from
97857d6 to
6418c78
Compare
RubenVanEldik
force-pushed
the
chore/add-typing
branch
from
6418c78 to
9dc115b
Compare
|
Hi, Could you please provide an update on whether this PR will be considered for merging? Any feedback or next steps would be greatly appreciated. Thank you! |
|
Hey @RubenVanEldik, we have your PR in our internal pipeline and we'll update here once we have an update. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typing support for logtail. This allows other repositories to use the type hints from logtail. Because Mypy does not support Python 3.7 anymore I removed this form the supported versions, there is currently only 1 downloader per week that uses Python 3.7. I also added support for Python 3.12, as this version is already over a year old.