Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Java stack trace's JAVAFILE to better match generated names #272

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Fix: Java stack trace's JAVAFILE to better match generated names #272

merged 3 commits into from
Jul 28, 2020

Conversation

kares
Copy link
Contributor

@kares kares commented Jul 28, 2020

As the specs demonstrates JAVAFILE wasn't matching RubyMethod$INVOKER$i$call.gen.

Context: we'll be adding some missing PATTERN specs for ECS and leaving a TODO for discovered 'broken' behavior (to be handled later) is confusing reviewers thus I decided to target some minor (potentially breaking) changes for 4.2.0 on their own.

... to be continued

@kares kares mentioned this pull request Jul 28, 2020
Merged
@andsel andsel self-requested a review July 28, 2020 08:40
andsel
andsel approved these changes Jul 28, 2020
View reviewed changes
Copy link

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 6ca234e into logstash-plugins:master Jul 28, 2020
kares added a commit that referenced this pull request Jul 31, 2020
@kares
Merge branch 'master' into ecs-wip
678ea3d 
* master:
  Fix: NAGIOS TIMEPERIOD unknown (from/to) field matching (#275)
  Fix: match Information/INFORMATION in LOGLEVEL (#274)
  Fix: Java stack trace's JAVAFILE to better match generated names (#272)
@kares kares mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel andsel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kares @andsel @elasticsearch-bot