Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding maven version to the list of default Grok patterns #130

Merged

Conversation

carlphilipp
Copy link
Contributor

No description provided.

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@carlphilipp
Copy link
Contributor Author

I just signed the CLA

@carlphilipp
Copy link
Contributor Author

When I run the test I have this error:

bundle exec rspec

Using Accessor#strict_set for specs
NoMethodError: undefined method `pattern_path' for LogStash::Environment:Module
Grok at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/logstash-filter-grok-2.0.3/lib/logstash/filters/grok.rb:222
(root) at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/logstash-filter-grok-2.0.3/lib/logstash/filters/grok.rb:139
require at org/jruby/RubyKernel.java:1071
require at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/polyglot-0.3.5/lib/polyglot.rb:65
(root) at /Users/charmant/git/logstash-patterns-core/spec/spec_helper.rb:1
require at org/jruby/RubyKernel.java:1071
(root) at /Users/charmant/git/logstash-patterns-core/spec/spec_helper.rb:11
load at org/jruby/RubyKernel.java:1087
(root) at /Users/charmant/git/logstash-patterns-core/spec/patterns/core_spec.rb:1
each at org/jruby/RubyArray.java:1613
(root) at /Users/charmant/git/logstash-patterns-core/spec/patterns/core_spec.rb:2
(root) at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1
load_spec_files at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105
load_spec_files at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105
setup at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:96
run at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:84
load at org/jruby/RubyKernel.java:1087
run at /Users/charmant/.rvm/gems/jruby-1.7.19/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:69
eval at org/jruby/RubyKernel.java:1107
(root) at /Users/charmant/.rvm/gems/jruby-1.7.19/bin/jruby_executable_hooks:15

@jsvd
Copy link
Member

jsvd commented Sep 15, 2016

can you move this into a separate file called maven and add a test to it? there are many examples already for other patterns

@karmi
Copy link

karmi commented Sep 15, 2016

Hi @carlphilipp, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@jsvd jsvd closed this Sep 15, 2016
@jsvd jsvd reopened this Sep 15, 2016
@carlphilipp
Copy link
Contributor Author

Hello @karmi, I updated my account with my other email, you should be able to verify it.
I also created a new file for maven, and some tests for it. Let me know if it's good enough, I'm not super familiar with Ruby

@jsvd
Copy link
Member

jsvd commented Sep 16, 2016

LGTM

@jsvd jsvd merged commit d435f8e into logstash-plugins:master Sep 16, 2016
@jsvd jsvd removed the needs tests label Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants