Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark deprecated SSL settings as obsolete #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robbavey
Copy link
Contributor

@robbavey robbavey commented Dec 2, 2024

This commit marks the following SSL settings as obsolete:

ssl_cert, which should be replaced by ssl_certificate
ssl_cacert, which should be replaced by ssl_certificate_authorities
ssl_enable, which should be replaced by ssl_enabled
ssl_verify, which should be replaced by ssl_client_authentication when mode is server or ssl_verification_modewhen mode is client

Relates: #58

This commit marks the following SSL settings as obsolete:

`ssl_cert`, which should be replaced by `ssl_certificate`
`ssl_cacert`, which should be replaced by `ssl_certificate_authorities`
`ssl_enable`, which should be replaced by `ssl_enabled`
`ssl_verify`, which should be replaced by `ssl_client_authentication` when `mode` is `server` or `ssl_verification_mode`when mode is `client`
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall removal looks complete. Just a few minor review comments I think are worth addressing.

spec/outputs/tcp_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the failed cell, looks like a transient issue. This looks good!

@robbavey robbavey requested a review from karenzone December 10, 2024 21:22
@robbavey
Copy link
Contributor Author

Ready for docs review @karenzone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants