-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark deprecated SSL settings as obsolete #58
base: main
Are you sure you want to change the base?
Conversation
This commit marks the following SSL settings as obsolete: `ssl_cert`, which should be replaced by `ssl_certificate` `ssl_cacert`, which should be replaced by `ssl_certificate_authorities` `ssl_enable`, which should be replaced by `ssl_enabled` `ssl_verify`, which should be replaced by `ssl_client_authentication` when `mode` is `server` or `ssl_verification_mode`when mode is `client`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall removal looks complete. Just a few minor review comments I think are worth addressing.
caca6cc
to
07b94e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarted the failed cell, looks like a transient issue. This looks good!
Ready for docs review @karenzone |
This commit marks the following SSL settings as obsolete:
ssl_cert
, which should be replaced byssl_certificate
ssl_cacert
, which should be replaced byssl_certificate_authorities
ssl_enable
, which should be replaced byssl_enabled
ssl_verify
, which should be replaced byssl_client_authentication
whenmode
isserver
orssl_verification_mode
when mode isclient
Relates: #58