Add new multiplex option to logstash-output-sqs plugin #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
CLA should be signed now. |
|
Any comments or questions on this PR? CLA was signed, and the Travis CI failures look unrelated. Would love to get this merged... Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option to allow multiplexing multiple Logstash event messages inside each SQS message. The logstash-input-sqs plugin already has support (via the standard 'json' codec) for demuxing such messages.
This plugin currently supports the use of SQS SendMessageBatch API; but SQS imposes a hard limit of ten messages per API call. By multiplexing instead, we can send potentially hundreds of messages per API call (depending on messages size). In local testing, I saw a 12x reduction in SQS API calls (corresponding to a 12x decrease in SQS costs on the AWS bill).
Tests, docs, etc still WIP; wanted to solicit feedback before going any further.
Thanks.