Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: cast true/false values for additional_settings #241

Merged
merged 4 commits into from
Oct 6, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Oct 6, 2021

This allows us to properly set additional AWS settings e.g.

output {
  s3 {
    ...
    additional_settings => {
      force_path_style => true
      ssl_verify_peer => false
    }
  }
}

NOTE: could be extended to cast Float/Integer but for now we're mostly after ssl_verify_peer => false ...

@kares kares marked this pull request as ready for review October 6, 2021 12:43
@kares kares requested review from kaisecheng and jsvd October 6, 2021 13:54
Copy link

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally with s3. LGTM

@kares kares removed the request for review from jsvd October 6, 2021 14:23
@kares kares merged commit ff42372 into logstash-plugins:master Oct 6, 2021
kares added a commit to kares/logstash-output-s3 that referenced this pull request Jun 14, 2022
* main:
  Feat: cast true/false values for additional_settings (logstash-plugins#241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants