Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify endpoint documentation #198

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Clarify endpoint documentation #198

merged 2 commits into from
Aug 20, 2019

Conversation

Pectojin
Copy link

@Pectojin Pectojin commented Nov 6, 2018

Clarified the need to explicitly declare HTTP or HTTPS in the endpoint URL.

Rune Henriksen added 2 commits November 6, 2018 19:59
Clarified the need to explicitly declare HTTP or HTTPS in the endpoint URL.
@karenzone
Copy link
Contributor

@Pectojin Thank you for your contribution. We are looking forward to reviewing it. Before we can, we need you to sign our CLA. Please feel free to contact me if you have questions. Thanks!

@Pectojin
Copy link
Author

Thanks for the heads up, I thought I had filled it out back when I made the PR but it must have slipped my mind.

Could you trigger the CLA check to re-run on your CI?

@karenzone
Copy link
Contributor

@Pectojin Thanks for your quick response.
It looks like the commits might be associated with a different email address. Could you add the second email address to your Github profile? (I think you can hide the address if you want to.) Thanks!

@Pectojin
Copy link
Author

Ah, yeah that makes sense, I used the wrong email in the signing. I've added that new email to the account so it should link up now.

@karenzone
Copy link
Contributor

Thank you! The CLA update is not triggering here, but I have verified.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and LGTM.

@karenzone
Copy link
Contributor

@Pectojin Thank you for helping us make our docs better! We appreciate your contribution.

@karenzone karenzone self-requested a review August 20, 2019 16:39
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone merged commit c9c3229 into logstash-plugins:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants