-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify endpoint documentation #198
Conversation
Clarified the need to explicitly declare HTTP or HTTPS in the endpoint URL.
@Pectojin Thank you for your contribution. We are looking forward to reviewing it. Before we can, we need you to sign our CLA. Please feel free to contact me if you have questions. Thanks! |
Thanks for the heads up, I thought I had filled it out back when I made the PR but it must have slipped my mind. Could you trigger the CLA check to re-run on your CI? |
@Pectojin Thanks for your quick response. |
Ah, yeah that makes sense, I used the wrong email in the signing. I've added that new email to the account so it should link up now. |
Thank you! The CLA update is not triggering here, but I have verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds cleanly and LGTM.
@Pectojin Thank you for helping us make our docs better! We appreciate your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Clarified the need to explicitly declare HTTP or HTTPS in the endpoint URL.