Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write_bucket_permission_validator doesn't use specified encryption settings #132

Closed
kushmansingh opened this issue Mar 10, 2017 · 1 comment
Closed

write_bucket_permission_validator doesn't use specified encryption settings #132

kushmansingh opened this issue Mar 10, 2017 · 1 comment
Assignees
@jakelandis

Comments

@kushmansingh
Copy link

This can be a problem if the bucket policy only allows for specific encryption eg.

{
	"Version": "2012-10-17",
	"Statement": [
		{
			"Sid": "DenyUnEncryptedObjectUploads",
			"Effect": "Deny",
			"Principal": "*",
			"Action": "s3:PutObject",
			"Resource": "arn:aws:s3:::myBucket/*",
			"Condition": {
				"Null": {
					"s3:x-amz-server-side-encryption": "true"
				}
			}
		}
	]
}
@jmcarp jmcarp mentioned this issue Aug 11, 2017
Closed
@jakelandis jakelandis self-assigned this Feb 7, 2018
@jakelandis
Copy link
Contributor

I believe that was fixed in 4.0.12. Please re-open if you find this to not be the case.

@asador asador mentioned this issue Jul 31, 2018
Closed
robbavey added a commit to robbavey/logstash-output-s3 that referenced this issue Aug 28, 2018
@robbavey
Fix bucket permission validation upload options
96022b5 
Pass 'upload_options' hash through to the bucket upload_test_file method to
fix issues where permission errors were happening when trying to validate
permissions on buckets with an 'encryption required' policy.

Fixes logstash-plugins#188, logstash-plugins#146, logstash-plugins#132
@robbavey robbavey mentioned this issue Aug 28, 2018
Closed
elasticsearch-bot pushed a commit that referenced this issue Aug 28, 2018
@robbavey
Fix bucket permission validation upload options
1bf83e2 
Pass 'upload_options' hash through to the bucket upload_test_file method to
fix issues where permission errors were happening when trying to validate
permissions on buckets with an 'encryption required' policy.

Fixes #188, #146, #132

Fixes #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelandis jakelandis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakelandis @kushmansingh