fix: avoid message in manticore exception logging context
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Logstash is configured to use JSON-formatted logs, the Log4j2 JSONLayout will serialize both the provided message and the context map's `message` in the same key/value collection. This is _syntactically_ valid, because JSON does not impose constraints on the uniqueness of keys in a key/value collection, but considered _semantically_ invalid by many parsers including Beats that attempt to deserialize into a structure that _do_ impose uniqueness constraints. Here we ensure that we provide the _contents_ of the exception's message inside a single message, without also providing a `message` key to the logging context.
|
FYI, this is a broader issue than just the elasticsearch output - elastic/logstash#14335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Logstash is configured to use JSON-formatted logs, the Log4j2 JSONLayout
will serialize both the provided message and the context map's
messageinthe same key/value collection. This is syntactically valid, because JSON
does not impose constraints on the uniqueness of keys in a key/value
collection, but considered semantically invalid by many parsers including
Beats that attempt to deserialize into a structure that do impose
uniqueness constraints.
Here we ensure that we provide the contents of the exception's message
inside a single message, without also providing a
messagekey to thelogging context.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/