Add extra safety to local data retrieval #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under certain cirumstances, retrieving local data from the embedded derby database can result in an exception being thrown from the Sequel library that is not wrapped in a `SequelError`. Prior to this commit, that would result in the exception "escaping" the plugin, causing the plugin (and the pipeline) to crash. This commit broadens the scope of the rescue to catch any errors that might result from that call, enabling the appropriate logging and tagging to take place without crashing the plugin. Fixes logstash-plugins#77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain cirumstances, retrieving local data from the embedded derby database
can result in an exception being thrown from the Sequel library that is not wrapped in
a
SequelError. Prior to this commit, that would result in the exception "escaping" theplugin, causing the plugin (and the pipeline) to crash.
This commit broadens the scope of the rescue to catch any errors that might result from
that call, enabling the appropriate logging and tagging to take place without crashing
the plugin.
Fixes #77