Fix: retry networking errors (with backoff) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
reviewed
Nov 16, 2020
| if error_count == 1 | ||
| raise Seahorse::Client::NetworkingError.new(Net::OpenTimeout.new, 'timeout') | ||
| end | ||
| if error_count == 3 |
There was a problem hiding this comment.
Is this combining two test scenarios? One, that the backoff resets after a successful run, and two, testing the NetworkingError class of events? Maybe split these into separate specs?
There was a problem hiding this comment.
yeah it is as I also wanted to test the sleep_time being reset after a successful invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of networking errors such as a timeout or a (temporary) failure to resolve DNS names the plugin should retry
resolves #56
resolves #55