Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Content-Type and Accept headers #55

Closed
jordansissel opened this issue Feb 1, 2017 · 4 comments
Closed

Set Content-Type and Accept headers #55

jordansissel opened this issue Feb 1, 2017 · 4 comments

Comments

@jordansissel
Copy link
Contributor

This is necessary to support elastic/elasticsearch#22691 when it lands. Without fixing this, this input will (likely?) not work against new Elasticsearch releases.

@jordansissel
Copy link
Contributor Author

Blocked on elastic/elasticsearch-ruby#400

@jordansissel
Copy link
Contributor Author

#56 works around it.

karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Feb 7, 2017
…' header

In future, Elasticsearch will require specifying the format of data which is being sent
 (eg. when indexing a document). Current versions of Elasticsearch will start to
 print a warning to the deprecation log.

 A default value 'application/json' for the 'Content-Type' header has been added
 to prevent the deprecation messages and to be prepared for the requirement in
 next major version of Elasticsearch.

 See: elastic/elasticsearch#22691

Related:

* c22ec89
* logstash-plugins/logstash-input-elasticsearch#55
* logstash-plugins/logstash-input-elasticsearch#56
* elastic/elasticsearch#22691

Closes #400
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Feb 7, 2017
…' header

In future, Elasticsearch will require specifying the format of data which is being sent
 (eg. when indexing a document). Current versions of Elasticsearch will start to
 print a warning to the deprecation log.

 A default value 'application/json' for the 'Content-Type' header has been added
 to prevent the deprecation messages and to be prepared for the requirement in
 next major version of Elasticsearch.

 See: elastic/elasticsearch#22691

Related:

* c22ec89
* logstash-plugins/logstash-input-elasticsearch#55
* logstash-plugins/logstash-input-elasticsearch#56
* elastic/elasticsearch#22691

Closes #400
@karmi
Copy link

karmi commented Feb 7, 2017

karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Feb 7, 2017
…nticore adapter

The Manticore adapter doesn't handle the `transport_options` in the same way
as the Faraday and Curb adapters.

The addition of a default 'Content-Type' header in 76f8679
(#400) didn't work then, and this patch fixes it.

Related:

    * #400
    * logstash-plugins/logstash-input-elasticsearch#55
    * logstash-plugins/logstash-input-elasticsearch#56
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Feb 7, 2017
…nticore adapter

The Manticore adapter doesn't handle the `transport_options` in the same way
as the Faraday and Curb adapters.

The addition of a default 'Content-Type' header in 76f8679
(#400) didn't work then, and this patch fixes it.

Related:

    * #400
    * logstash-plugins/logstash-input-elasticsearch#55
    * logstash-plugins/logstash-input-elasticsearch#56
andrewvc added a commit to andrewvc/logstash-input-elasticsearch that referenced this issue Feb 7, 2017
andrewvc added a commit to andrewvc/logstash-input-elasticsearch that referenced this issue Feb 7, 2017
@karmi
Copy link

karmi commented Feb 7, 2017

Version https://rubygems.org/gems/elasticsearch-transport/versions/5.0.3 released, which addresses a bug in the Manticore adapter when handling options.

andrewvc added a commit to andrewvc/logstash-input-elasticsearch that referenced this issue Feb 7, 2017
picandocodigo pushed a commit to elastic/elastic-transport-ruby that referenced this issue Jun 7, 2021
…' header

In future, Elasticsearch will require specifying the format of data which is being sent
 (eg. when indexing a document). Current versions of Elasticsearch will start to
 print a warning to the deprecation log.

 A default value 'application/json' for the 'Content-Type' header has been added
 to prevent the deprecation messages and to be prepared for the requirement in
 next major version of Elasticsearch.

 See: elastic/elasticsearch#22691

Related:

* c22ec891b0be0e3e8f3c10fd7844adfbd2d608ed
* logstash-plugins/logstash-input-elasticsearch#55
* logstash-plugins/logstash-input-elasticsearch#56
* elastic/elasticsearch#22691

Closes #400
picandocodigo pushed a commit to elastic/elastic-transport-ruby that referenced this issue Jun 7, 2021
…nticore adapter

The Manticore adapter doesn't handle the `transport_options` in the same way
as the Faraday and Curb adapters.

The addition of a default 'Content-Type' header in 76f86793cde0a0e7e816a743c73f69002a53483e
(#400) didn't work then, and this patch fixes it.

Related:

    * elastic/elasticsearch-ruby#400
    * logstash-plugins/logstash-input-elasticsearch#55
    * logstash-plugins/logstash-input-elasticsearch#56
renaperes824 added a commit to renaperes824/ruby-elastic-transport that referenced this issue Sep 12, 2022
…' header

In future, Elasticsearch will require specifying the format of data which is being sent
 (eg. when indexing a document). Current versions of Elasticsearch will start to
 print a warning to the deprecation log.

 A default value 'application/json' for the 'Content-Type' header has been added
 to prevent the deprecation messages and to be prepared for the requirement in
 next major version of Elasticsearch.

 See: elastic/elasticsearch#22691

Related:

* c22ec891b0be0e3e8f3c10fd7844adfbd2d608ed
* logstash-plugins/logstash-input-elasticsearch#55
* logstash-plugins/logstash-input-elasticsearch#56
* elastic/elasticsearch#22691

Closes #400
renaperes824 added a commit to renaperes824/ruby-elastic-transport that referenced this issue Sep 12, 2022
…nticore adapter

The Manticore adapter doesn't handle the `transport_options` in the same way
as the Faraday and Curb adapters.

The addition of a default 'Content-Type' header in 76f86793cde0a0e7e816a743c73f69002a53483e
(#400) didn't work then, and this patch fixes it.

Related:

    * elastic/elasticsearch-ruby#400
    * logstash-plugins/logstash-input-elasticsearch#55
    * logstash-plugins/logstash-input-elasticsearch#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants