-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added executor_threads documentation #421
Conversation
Here was a parallel one: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a minimal suggestion
that description is more extended, we could use that, and close that draft PR with this one |
Hi @111andre111 I've rebased to |
Yes correct @111andre111, but Changelog needs a fix |
@andsel I have fixed now the Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this important documentation. Nice job explaining it. I left some minor suggestions inline for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge squashing the commits please, or ping me if you need I do it
@andsel Sorry if I didn't manage the squash. I always got an error message. |
@111andre111 I've rebased to |
Ah I see. I didn't see that. Thank you @andsel |
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/