-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure event Hub client library to version 3.3.0 #96
Merged
andsel
merged 10 commits into
logstash-plugins:main
from
andsel:fix/update_azure_client_library
Oct 25, 2024
Merged
Update Azure event Hub client library to version 3.3.0 #96
andsel
merged 10 commits into
logstash-plugins:main
from
andsel:fix/update_azure_client_library
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessorHost using the EventProcessorHostBuilder
With version 3 of the library EventProcessorHost cosntructor has been replaced by EventProcessorHost.EventProcessorHostBuilder. The tests was updated to mock the builder and not the constructor.
andsel
changed the title
Updated azure-eventhubs to 3.3.0 adapting the instantiation of EventP…
Update Azure event Hub client library to version 3.3.0
Oct 23, 2024
…ld step and not runtime execution
…g the vendor. This avoid to have require_jar calls that doesn't find the expected file
jsvd
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change needed for the nimbus-jose-jwt dependency, otherwise LGTM
require_jar('com.github.stephenc.jcip', 'jcip-annotations', '1.0-1') | ||
require_jar('com.google.guava', 'guava', '32.0.1-jre') | ||
require_jar('com.nimbusds', 'lang-tag', '1.7') | ||
require_jar('com.nimbusds', 'nimbus-jose-jwt', '9.8.1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
require_jar('com.nimbusds', 'nimbus-jose-jwt', '9.8.1') | |
require_jar('com.nimbusds', 'nimbus-jose-jwt', '9.37.2') |
Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Updated Azure Event Hub client library to version 3.3.0
What does this PR do?
Updates azure-eventhubs to 3.3.0 and all its dependencies.
Why is it important/What is the impact to the user?
Permit to use a newer library.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Gemfile
with:and update with
bin/logstash-plugin install --no-verify
Related issues