Workaround to avoid errors that cause plugin to crash on Java 11 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running this plugin under Java 11, calls to event_processor_host.getHostContext.getEventHubPath can fail with `org.jruby.exceptions.NoMethodError: (NoMethodError) undefined method `getEventHubPath'` This can be avoided by removing the calls to this method, which is only used in logging calls and is unnecessary - the value is the same as that held in the `event_hub_name`
|
Thanks @jsvd! |
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 28, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this plugin under Java 11, calls to event_processor_host.getHostContext.getEventHubPath
can fail with
org.jruby.exceptions.NoMethodError: (NoMethodError) undefined methodgetEventHubPath'`This can be avoided by removing the calls to this method, which is only used in logging calls and is
unnecessary - the value is the same as that held in the
event_hub_name