Updated Nokogiri version #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so Logstash >= 8.4.0
andsel
force-pushed
the
fix/update_nokogiri
branch
from
49a04c5 to
e5d426a
Compare
jsvd
requested changes
Aug 16, 2022
|
@jsvd I've update the matrix, I've left the |
jsvd
reviewed
Aug 16, 2022
.ci/travis/matrix.yml
Outdated
| @@ -0,0 +1,28 @@ | |||
| _performance: &_performance | |||
There was a problem hiding this comment.
Instead of editing the matrix.yml you can just directly edit the travis.yml of this repo: https://github.com/logstash-plugins/logstash-filter-xml/pull/80/files.
You can see that the tests for that PR respect the build matrix from travis.yml of the PR itself: https://app.travis-ci.com/github/logstash-plugins/logstash-filter-xml/builds/254472445
There was a problem hiding this comment.
Thank's @jsvd for the hint, I fixed that and now the matrix build work as expected.
jsvd
reviewed
Aug 17, 2022
Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Nokogiri dependency version