Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non valid XML Content documentation #72

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

111andre111
Copy link
Contributor

Added documentation regarding non valid characters

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

Added documentation regarding non valid characters
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @111andre111. Another nice docs contribution. Thank you!

I left a minor suggestion for rewording for your consideration. Please let me know what you think or if you'd like to discuss.

docs/index.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Karen Metts <[email protected]>
@111andre111 111andre111 requested a review from karenzone December 3, 2021 22:35
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this helpful info. Builds cleanly and LGTM.

@karenzone karenzone merged commit d6cca81 into logstash-plugins:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants