Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated xsl reference documentation for xpath url #70

Merged
merged 6 commits into from
Dec 7, 2021

Conversation

111andre111
Copy link
Contributor

@111andre111 111andre111 commented Apr 24, 2020

At the moment this particular Url doesn't work and points to the wrong url.
So I corrected that here.

At the moment this particular Url doesn't work and points to the wrong url.
So I corrected that here.
Another wrong link reference
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice docs contribution, @111andre111. Thank you!

I left some suggestions inline for your consideration. Suggestions include adding another heading to draw more attention to this info, and making XPath function the actual link text so that it will score higher in SEO and be easier for users to find.

Let me know what you think and if you would like to discuss.

docs/index.asciidoc Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
@111andre111 111andre111 requested a review from karenzone December 3, 2021 22:40
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this helpful info. Builds cleanly and LGTM.

@karenzone karenzone merged commit 0ecbe59 into logstash-plugins:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants