Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dictionary definition passed into the spec methods #104

Merged

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Jun 6, 2023

Fix dictionary definition passed into the spec methods, to be compliant with JRuby 9.4

How to test

Same steps as logstash-plugins/logstash-filter-cidr#26 but adding

-J-Djruby.regexp.interruptible=true

to the JRUBY_OPTSenvironment variable

Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I only see the changes in the array, not JRUBY_OPTS?

So approving the array changes here.

If you need to add the JRUBY_OPTS< please put a follow up branch.

@andsel
Copy link
Contributor Author

andsel commented Jun 14, 2023

JRUBY_OPTS it' need only when using the plain JRuby installed on the system. When tested on CI it uses the JRuby provided by Logstash which is already configured with this setting.

@andsel andsel merged commit cdabd65 into logstash-plugins:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants