Change condition expression to disable services #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition that checks the properties to enable/disable services (`logsearch.logs.enabled` and `logsearch.metrics.enabled`) do not work as expected. It only checks if the property is defined with the `if_p`, and that always evaluate to true regardless the value of the property, even when the value is `false:FalseClass`. Because that, there is no way to actually disable the services. Instead of checking if the property is defined, we must check if the value of the property evals to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition that checks the properties to enable/disable services
(
logsearch.logs.enabledandlogsearch.metrics.enabled) do notwork as expected.
It only checks if the property is defined with the
if_p, and that alwaysevaluate to true regardless the value of the property, even when
the value is
false:FalseClass. Because that, there is no way toactually disable the services.
Instead of checking if the property is defined, we must check if the
value of the property evals to true.