feat: transaction status #181
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agazso
force-pushed
the
feat/transaction-status
branch
from
62def17
to
c1758bc
Compare
| token: z.object({ | ||
| amount: z.string(), | ||
| symbol: z.string(), | ||
| decimals: z.number().int().positive(), | ||
| }), | ||
| to: AddressSchema, | ||
| from: AddressSchema, | ||
| fee: z.object({ | ||
| amount: z.string(), | ||
| symbol: z.string(), | ||
| decimals: z.number().int().positive(), | ||
| }), |
There was a problem hiding this comment.
Let's keep it as is right now, but later on we should think about whether we don't want to use token address instead of symbol as symbols can be ambiguous (although they should not)
There was a problem hiding this comment.
Please rename the initializeBalances to fetchBalances.
I would also love to keep the firebase adapter do everything just in the firebase db (including all transactions etc). I am fine to merge this PR but then I would love to restore the way it originally worked just as we discussed.
| async function _checkBalance(token: Token): Promise<void> { | ||
| await checkBalance(address, token) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why does the object check balances? Shouldn't the app be just checking the balances onload and maybe periodically?
There was a problem hiding this comment.
It's because the balance is get through polling and with polling there is always a tradeoff that you either make too many polls and waste resources or too few and then it may be a poor user experience.
I think we should check the balance periodically (let's say once in every minute or so) but if there is a transaction done and it can be expected that changes the balance then it would be good to keep to possibility to force a checkBalance.
With this PR the Payggy object is able to set the status of the transactions on the backend correctly and update it with messages. It only sends the transaction hash in the messages and the peer in the chat reads the transaction from the blockchain based on that.
What is done:
onMessagecallback async, no longer returns the updated storeupdateStorefunction passed as argumentKnown issues:
Tokentype so that it does not containamountfield #177) in this PR, but it was very annoying. I suggest removing theamountfrom theTokentype, and creating anAmounttype which could have atokenand avalueproperty.ethers@v6.ethers@v5would work. Workaround was to set up an alternative endpoint running a different execution client. (JSON RPC - Fix differences between Nethermind and Infura (tested by flood) NethermindEth/nethermind#5921 and getTransaction() error ethers-io/ethers.js#3835)toBigIntcauses unhandled exception #182onMessagearguments now. It would be better to just have two arguments, oneDataMessageand oneWakuObjectArgs. I would also rename the latter toWakuObjectContext.