Handling Unexpected token error #2
Conversation
| console.log(result.response); | ||
| } | ||
| }); | ||
| if (res.statusCode === 200) { |
There was a problem hiding this comment.
Is 200 response and response.ok equivalent? If so, then we only need one of them to run context.succeed?
There was a problem hiding this comment.
@kevinegami, No, they are not same. res.statusCode only returns numeric status code so the first if check is to match the returned HTTP status code and the second if check is to match the returned parsing result in result variable. The result variable has nothing to do with the 200 response.
There was a problem hiding this comment.
So we can get a 200 status code but response.ok !== True? Seems odd for an API.
There was a problem hiding this comment.
I understand there is a status code and a response and they are NOT the same, but for a 200 status code shouldn't they be?
Hi @dmr-loggly, @kevinegami,
In this PR, I'm handling the code break when parsing the HTML/XML response from server. The script sometime breaks at line #105 when the returned response is not a valid JSON. So I'm allowing parsing only when the success is returned and status code is 200.
Please review and merge. Thanks!